ppc64le core-bpf testing and PR testing #1448

Stringy · 2023-11-29T11:16:37Z

Description

Should enable core-bpf testing for ppc64le. Once it is working/failing, I'll rebase it over the vanilla branch.

Checklist

Investigated and inspected CI test results
Updated documentation accordingly

Automated testing

Added unit tests
Added integration tests
Added regression tests

If any of these don't apply, please comment below.

Testing Performed

TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why you did not do so. (Valid reasons include "CI is sufficient" or "No testable changes")
In addition to reviewing your code, reviewers must also review your testing instructions, and make sure they are sufficient.

For more details, ref the Confluence page about this section.

openshift-ci · 2023-11-29T11:16:42Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

erthalion

Thanks, looks good. I've left few commentaries, but suggest to follow up on them in a separate PR. Otherwise not sure what's your plan to proceed -- s390x tests seems to pass, but few others are failing, is that expected?

erthalion · 2023-12-21T13:23:11Z

.github/workflows/collector-builder.yml

@@ -11,11 +11,12 @@ on:
    outputs:
      collector-builder-tag:
        description: The builder tag used by the build
-        value: ${{ jobs.build-builder-image.outputs.collector-builder-tag || 'master' }}
+        value: ${{ jobs.build-builder-image.outputs.collector-builder-tag || '3.16.x-195-g8f32e71fad' }}


What was this image exactly? And would it be dropped before merging?

This was taken from mauro's original vanilla PR and will be dropped before merging.

erthalion · 2023-12-21T13:25:56Z

.github/workflows/collector-builder.yml

@@ -110,6 +143,24 @@ jobs:
            -e @'${{ github.workspace }}/ansible/secrets.yml' \
            ansible/ci-build-builder.yml

+      - name: Build s390x images


This feels a bit weird, is it easier to build s390x images in a separate step, not as part of the previous one?

For now, yeah it's a little simpler, just because we can force the previous step to use localhost only, but this step will use the entire inventory (which is only one VM at the moment)

When I implement full multi-arch native builds I'll hopefully combine these steps

erthalion · 2023-12-21T13:41:20Z

.github/workflows/collector-slim.yml

-          ANSIBLE_CONFIG: ansible/ansible.cfg
+          VM_TYPE: rhel-s390x
+
+      - name: Save CMake cache


Will this cache be used automatically, or does it have to be explicitly included? It's probably a good idea to add a condition to allow running without cache if specified via a label.

This was just for debugging the build, I'll remove it.

erthalion · 2023-12-21T13:47:23Z

ansible/ci-build-collector-full.yml

@@ -19,7 +19,7 @@
    - name: Build full image
      when:
        - build_full_image
-        - arch != 'arm64'
+        - arch != 'arm64' and arch != 'ppc64le' and arch != 's390x'


This is the part where we temporarily disable full builds for multi-arch, right?

yeah, it is. I'll remove before merging.

erthalion · 2023-12-21T13:48:24Z

ansible/ci-build-builder.yml

+        version: "{{ collector_git_sha }}"
+        refspec: "+{{ collector_git_ref | replace('refs/', '') }}"
+        recursive: true
+      when: arch == "s390x"


Not sure I follow, why to clone only for s390x?

Because it's the only platform (currently) that is building on a separate machine to the GHA runner. All the other platforms can build from the existing checked out source

Stringy · 2024-01-02T10:16:07Z

s390x tests seems to pass, but few others are failing, is that expected?

Seems to have been an SSH key mix up following my ansible changes; I've fixed that now so this run should pass 🤞

openshift-ci bot added the do-not-merge/work-in-progress label Nov 29, 2023

Stringy added build-full-images run-multiarch-builds Run steps for non-x86 archs. labels Nov 29, 2023

Stringy force-pushed the giles/ppc64le-core-bpf-testing branch from b093279 to 40d3d97 Compare November 30, 2023 13:19

Stringy changed the base branch from master to mauro/use-falco-upstream November 30, 2023 13:19

Stringy marked this pull request as ready for review November 30, 2023 13:20

Stringy requested a review from a team as a code owner November 30, 2023 13:20

openshift-ci bot removed the do-not-merge/work-in-progress label Nov 30, 2023

Stringy force-pushed the giles/ppc64le-core-bpf-testing branch from 40d3d97 to e86fcce Compare December 1, 2023 13:31

Stringy force-pushed the mauro/use-falco-upstream branch from 73a3609 to c6b7918 Compare December 1, 2023 13:49

Stringy force-pushed the giles/ppc64le-core-bpf-testing branch from e86fcce to 622b6d6 Compare December 1, 2023 13:57

Stringy added build-builder-image and removed build-builder-image labels Dec 5, 2023

Stringy force-pushed the giles/ppc64le-core-bpf-testing branch from bdfede0 to 81d8f68 Compare December 8, 2023 08:37

Stringy added the integration-tests-trace-logging Turn on additional logging in Collector label Dec 12, 2023

Stringy force-pushed the giles/ppc64le-core-bpf-testing branch 10 times, most recently from 4e05a88 to de0f77e Compare December 20, 2023 12:49

Stringy mentioned this pull request Dec 20, 2023

Run multiarch builds natively rather than via QEMU #1479

Closed

erthalion reviewed Dec 21, 2023

View reviewed changes

erthalion approved these changes Jan 3, 2024

View reviewed changes

Stringy added 27 commits January 3, 2024 08:52

Fix GCP ssh key file

47381d2

Use VM_TYPE for build VMs

4e981e6

Add git and make to redhat provisioning

99b9913

Fixes for VM destruction and git refs

33020f0

Adds refspec for git clone

5aca66c

Env fixes for VM destruction

ccbdfc6

Fix git ref in builder build

abff0bb

Remove version from git clone

5bb5308

Remaining fixes for slim builds

25dc68b

Bump ibm disk size for CI

55bd76a

Temp drop ppc64le and arm builders

86b4032

typo

90eedf1

Fixes rhacs_eng_image use in ansible build

b29ddfe

clean up and fixes for test vms and power

9cc4289

Couple of fixes for python deps and inventory naming scheme

c406b5a

Consolidates ansible vars and fixes remote checkout

4618253

Fix build hosts

050b8eb

Remove refs/ prefix from git ref

2bff037

Fix GCP ssh key file

6f685f1

Reenable other archs and some cleanup

c2b1421

Moves vm creation into workflows to allow re-running of failed steps

2631830

Fix ibm_env default

c81c566

Fix amd64 vm creation

85a34c4

Fix GCP ssh key file by using a new GCP specific group

26ab212

Remove CMake Cache upload

44f93f2

Fix ppc64le destruction (api key mismatch)

b8b1b67

Fix region and zone in ppc64le destroy

dc521ae

Stringy force-pushed the giles/ppc64le-core-bpf-testing branch from 5528455 to dc521ae Compare January 3, 2024 08:54

Stringy merged commit 16fa1e4 into mauro/use-falco-upstream Jan 3, 2024
84 of 85 checks passed

Stringy deleted the giles/ppc64le-core-bpf-testing branch January 3, 2024 13:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ppc64le core-bpf testing and PR testing #1448

ppc64le core-bpf testing and PR testing #1448

Stringy commented Nov 29, 2023

openshift-ci bot commented Nov 29, 2023

erthalion left a comment

erthalion Dec 21, 2023

Stringy Jan 2, 2024

erthalion Dec 21, 2023

Stringy Jan 2, 2024

erthalion Dec 21, 2023

Stringy Jan 2, 2024

erthalion Dec 21, 2023

Stringy Jan 2, 2024

erthalion Dec 21, 2023

Stringy Jan 2, 2024

Stringy commented Jan 2, 2024

ppc64le core-bpf testing and PR testing #1448

ppc64le core-bpf testing and PR testing #1448

Conversation

Stringy commented Nov 29, 2023

Description

Checklist

Testing Performed

openshift-ci bot commented Nov 29, 2023

erthalion left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Stringy commented Jan 2, 2024